News for hackers. Stuff that matters.

A comment on Director of Eng gave me surprisingly poor feedback. Should I escalate to VP?.

Re:Director of Eng gave me surprisingly poor feedback. Shoul... by mytailorisrich on Monday May 10, 2021 @09:54AM (#27105994)
> Rather than linting before pushing, I enjoy waiting for Hound's comments and fixing them afterward.

That's a poor practice, IMO.

A PR should mean that code is ready to merge, so it must have been linted and tested beforehand, so I agree with Director of Eng that there should be little chatter.

This probably goes hand in hand with your practice of opening "draft PR".

Now, if Hound is only accessible to you that way and you think it is a valuable tool to use before opening a PR then this may be a worthwhile discussion to have with him.

[ Parent | on HN ]
Re:Director of Eng gave me surprisingly poor feedback. Shoul... by ciisforsuckas on Monday May 10, 2021 @10:02AM (#27106066)
yes and this is why a lot of us have started runnning CI on PR's and failing PR's if they don't pass basic quality gateways like linting.
[ Parent | on HN ]