News for hackers. Stuff that matters.
Re:Cinder: Instagram's performance-oriented fork of CPython by nine_k on Tuesday May 04, 2021 @08:33PM (#27044623)
I don't see why JIT cannot use type annotations to speed up the code.

But JIT also works on untyped or incompletely typed code.

Re:Cinder: Instagram's performance-oriented fork of CPython by wiml on Tuesday May 04, 2021 @09:32PM (#27045082)
According to the pypy people, the type annotations also don't provide the kind of information the JIT wants. The JIT cares about things like "this integer fits into a machine word" and "this parameter can be None but is almost always not None" so on. The type system doesn't concern itself with that.
Re:Cinder: Instagram's performance-oriented fork of CPython by _carljm on Wednesday May 05, 2021 @09:00AM (#27049295)
It’s definitely true that there’s stuff a JIT would love to know that the type system can’t tell you. But that doesn’t mean there isn’t useful information available in type annotations. In particular it is possible to speed up attribute access and method/function calls a lot when target types are statically known.

Our approach to “int fits in a machine word” in Static Python is to require machine ints to be explicitly annotated as such, and then you opt in to limited size ints with overflow etc, in exchange for getting really fast arithmetic.

Re:Cinder: Instagram's performance-oriented fork of CPython by rtpg on Tuesday May 04, 2021 @08:51PM (#27044768)
I mean if you care about perf you can do it in one step. It’s not that huge of an ask, and engineering wise “compile some typed code” is a hell of a lot more straightforward than “try to guess what I should speculatively compile at runtime”

There was a piece by v8 devs a while back where they ended up turning down JIT aggressiveness cuz it ended up making normal web pages slower (except for like Google Docs).

This is just me backseat-BDFLing “why do the hard thing when we could do the easy thing” tho

Re:Cinder: Instagram's performance-oriented fork of CPython by nine_k on Tuesday May 04, 2021 @10:28PM (#27045494)
Typing a large legacy codebase written in a highly dynamic language is not as easy. Instagram is pretty large.

I have seen a very large codebase in a dynamic language at [redacted] that has been mostly converted to use a sophisticated type system. Certain core things have not been converted so far, though, but just marked with a lot of "proceed with caution" and "TODO" red flags. Making them typesafe in any conceivable way would break compatibility for large subsystems.

Sometimes a rewrite is the only way out of such a situation, but very few can afford it.

Re:Cinder: Instagram's performance-oriented fork of CPython by huac on Tuesday May 04, 2021 @11:04PM (#27045726)
Instagram wrote https://github.com/Instagram/MonkeyType to help type their Python code
Re:Cinder: Instagram's performance-oriented fork of CPython by kingmaker on Wednesday May 05, 2021 @03:35AM (#27047181)
A couple of the folks who wrote MonkeyType (me and _carljm) also work on Cinder :)
Re:Cinder: Instagram's performance-oriented fork of CPython by friendzis on Wednesday May 05, 2021 @06:51AM (#27048346)
> Typing a large legacy codebase written in a highly dynamic language is not as easy. > very few can afford it.

Starting a project in a highly dynamic language is a conscious choice with well-known properties. The second part is interesting, however. Essentially you are saying that gains from development velocity do not offset losses from technical debt, which is a strange observation. I would say it sort of hints at time to MVP being irrelevant business metric (startup runway/survivability aside) at best. This is contrary to typical startup truths.

Re:Cinder: Instagram's performance-oriented fork of CPython by nine_k on Wednesday May 05, 2021 @02:49PM (#27054049)
At a certain scale, they do. Case in point: Twitter. They went through a painful transition but they did not have much choice.

But sometimes they don't. Case in point: YouTube, Instagram. Both of them are slowly migrating more and more Python code to different languages, but the amount of Python is still large, and AFAIK neither has plans to eschew it completely.

Time to MVP is a very relevant business metric. But the same thing that speeds you up in the beginning slows you down later on. If you architect your code past MVP to help replace the implementations of critical paths, it may help you down the line. (Micro)service architecture is one way to do that.

Re:Cinder: Instagram's performance-oriented fork of CPython by nimish on Tuesday May 04, 2021 @08:48PM (#27044740)
There's no requirement that type annotations be accurate.

With hidden classes and such it likely wouldn't matter much. You'd need them anyway for full dynamism

Re:Cinder: Instagram's performance-oriented fork of CPython by _carljm on Wednesday May 05, 2021 @08:56AM (#27049263)
With Static Python we use type annotations in compilation, and we require them to be correct (they are runtime checked at boundaries with non-Static code and throw TypeError if wrong types are passed in.)

We haven’t gone the hidden classes route so far because it’s simpler to just look at attributes assigned in __init__ and annotated on the class and lock those into slots. If you’re writing typed Python you probably don’t do a lot of tacking extra ad hoc attributes onto instances, since type checkers don’t like that either.

Re:Cinder: Instagram's performance-oriented fork of CPython by _carljm on Wednesday May 05, 2021 @08:57AM (#27049267)
Our JIT can use type information when available to improve speed. This is what the Static Python project described in the README is all about.