News for hackers. Stuff that matters.

A comment on Stacked Diffs versus Pull Requests (2018). Parent comment

Re:Stacked Diffs versus Pull Requests (2018) by pritambaral on Saturday April 24, 2021 @10:50PM (#26929975)
You're still missing the point: diff of diffs. When GitHub compares two commits, it diffs the whole repo as of one commit against the other (like `git diff commitA commitB); what is requested is diffing the change contained in one commit against the other (like `diff <(git show commitA) <(git show commitB)`).

PS: I checked out your demo. I can't see how to diff arbitrary commits, only revisions of a PR.

[ Parent | on HN ]
Re:Stacked Diffs versus Pull Requests (2018) by piotrkaminski on Saturday April 24, 2021 @11:36PM (#26930159)
IIUC, you're looking for true diffs between revisions with different bases. If so, Reviewable deals with that automatically, running 4 separate diffs in the background and integrating the results so that base-only diffs are hidden by default.

As for diffing commits, you can switch a review into "review each commit" mode so that it will create one revision per commit. You can make this the default for a repo but it's not in the demo as it's not the most common way to work. The demo does really need updating, though!

[ Parent | on HN ]