iCloud Keychain is ‘good enough’ if you are 100% in the Apple ecosystem, but there’s a lot it could do better, including password sharing as well as password export. Most glaringly there’s no support for storing additional meta data alongside the password; eg all the made up answers to “what was the street you grew up on?”, etc