Re:Best practices for writing SQL queries
by warent on Saturday April 10, 2021 @01:26PM
(#26763214)
this seems like taking on a pretty huge risk for a minor convenience. the difference between those two queries can mean the difference between protecting someone's PII
[ Parent
| on HN ]
Re:Best practices for writing SQL queries
by carbocation on Saturday April 10, 2021 @02:22PM
(#26763700)
I'm not sure that I follow. The two queries are to demonstrate difference in form; they are not intended to be equivalent.
If you're already writing:
WHERE foo=bar
AND biz=baz
It's not clear to me how: WHERE TRUE
AND foo=bar
AND biz=baz
is worse.
Re:Best practices for writing SQL queries
by shazzdeeds on Saturday April 10, 2021 @03:22PM
(#26764251)
Heβs saying if someone gets in the habit of using that style they have to be very careful. If they forget to change True to False when using an OR that it could have major consequences. Performance being the least of concerns.
Re:Best practices for writing SQL queries
by carbocation on Tuesday April 13, 2021 @09:53PM
(#26802071)
I agree that such an error would be of the catastrophic type. It's interesting that several people seem to perceive this formatting approach as something that would increase the risk of that error. Is the red flag for people the WHERE TRUE on one line? Like, would this be less alarming to people?
WHERE
TRUE
AND x=y