News for hackers. Stuff that matters.
Re:Comparative unsafety by ncmncm on Friday April 09, 2021 @11:08AM (#26751462)
No one checks close()'s result because it lies.

What should you write,

  while (close(fd) != 0) {}
? Or does it risk getting an infinite loop if, e.g., some network connection disappears?

Maybe

  if (fsync(fd) == 0) 
    while (close(fd) != 0) {}
  else abort();
But maybe fsync is interruptible too.

Ultimately there is nothing strictly correct to write, and you should just not really count on files being closed before process termination, but call close() as an optimization not to leak too many fds.

Re:Comparative unsafety by cesarb on Friday April 09, 2021 @11:14AM (#26751553)
You cannot retry close(). Quoting from https://man7.org/linux/man-pages/man2/close.2.html#NOTES

       Retrying the close() after a failure return is the wrong thing to
       do, since this may cause a reused file descriptor from another
       thread to be closed.  This can occur because the Linux kernel
       always releases the file descriptor early in the close operation,
       freeing it for reuse; the steps that may return an error, such as
       flushing data to the filesystem or device, occur only later in
       the close operation.
That is, once you call close(), the file descriptor is always freed (even if close() returns an error), and can be reused for an open() or similar in another thread. Retrying the close() will fail with EBADF in the best case, and close something another thread has opened in the worst case.
Re:Comparative unsafety by OskarS on Friday April 09, 2021 @04:06PM (#26755411)
So what is the point of it having a return value at all then?
Re:Comparative unsafety by einpoklum on Saturday April 10, 2021 @02:04PM (#26763543)
> What should you write?

You should try closing once, and if it fails, either die (e.g. with abort() ), or do something meaningful and relevant to your specific situation.

> Ultimately there is nothing strictly correct to write,

If that is the case for you - then definitely abort().

Re:Comparative unsafety by rectang on Friday April 09, 2021 @11:27AM (#26751733)
> No one checks close()'s result because it lies.

And since nobody checks the result of close and very few check the result of every single write operation, many "disk full" errors go unnoticed.

Re:Comparative unsafety by ncmncm on Friday April 09, 2021 @03:56PM (#26755301)
If you want to know whether your writes are getting out, you will get a much more reliable indication from fsync(). So, instead of exhorting people to check close()'s result, you should exhort them to fsync() first and check that result.

A very old programming principle says, "Never check for any failure you are not equipped to act on." It is sometimes used as a reminder to ensure you are always so equipped.

Re:Comparative unsafety by Jweb_Guru on Saturday April 10, 2021 @02:14AM (#26759355)
> A very old programming principle says, "Never check for any failure you are not equipped to act on." It is sometimes used as a reminder to ensure you are always so equipped.

This sounds like a great principle for allowing dangerous bugs to linger in a codebase for years... one can always act upon a failure by aborting.

Re:Comparative unsafety by rectang on Friday April 09, 2021 @05:54PM (#26756673)
My understanding is fsync() will tell you more than close() only when a flush of the OS cache fails to make it to disk. Is there anything else?

The problem with calling fsync() is that you have to wait for it to finish. There are many scenarios where the extra data integrity guarantees you get from calling fsync() aren't important.

Re:Comparative unsafety by ncmncm on Friday April 09, 2021 @09:53PM (#26758256)
close() will fail to report a wide variety of failures.

But Cesar is right, you can't re-try it. And fsync() can be very slow on most commonly-used file systems. We are fortunate that now SSDs are fast.

Re:Comparative unsafety by einpoklum on Saturday April 10, 2021 @02:06PM (#26763568)
fsync() is not part of the standard C library. You won't be able to use it on, say, MS Windows. (Although maybe rust has it?)
Re:Comparative unsafety by ncmncm on Saturday April 10, 2021 @04:34PM (#26764902)
Neither are open(), close(), or, indeed, file descriptors.

But they are all in Posix, which is ISO Standard 9945, based on IEEE 1003.1.

Windos has various gestures toward Posix compatibility, which might include _close() and _fsync().

Unix and Posix file system semantics are not among the best achievements of the Unix philosophy or of Posix as a universal system interface, but they have been considered "good enough" by most for a long enough time to make an actually-good replacement increasingly unlikely to take hold.