Retrying the close() after a failure return is the wrong thing to
do, since this may cause a reused file descriptor from another
thread to be closed. This can occur because the Linux kernel
always releases the file descriptor early in the close operation,
freeing it for reuse; the steps that may return an error, such as
flushing data to the filesystem or device, occur only later in
the close operation.
That is, once you call close(), the file descriptor is always freed (even if close() returns an error), and can be reused for an open() or similar in another thread. Retrying the close() will fail with EBADF in the best case, and close something another thread has opened in the worst case.You should try closing once, and if it fails, either die (e.g. with abort() ), or do something meaningful and relevant to your specific situation.
> Ultimately there is nothing strictly correct to write,
If that is the case for you - then definitely abort().
And since nobody checks the result of close and very few check the result of every single write operation, many "disk full" errors go unnoticed.
A very old programming principle says, "Never check for any failure you are not equipped to act on." It is sometimes used as a reminder to ensure you are always so equipped.
This sounds like a great principle for allowing dangerous bugs to linger in a codebase for years... one can always act upon a failure by aborting.
The problem with calling fsync() is that you have to wait for it to finish. There are many scenarios where the extra data integrity guarantees you get from calling fsync() aren't important.
But Cesar is right, you can't re-try it. And fsync() can be very slow on most commonly-used file systems. We are fortunate that now SSDs are fast.
But they are all in Posix, which is ISO Standard 9945, based on IEEE 1003.1.
Windos has various gestures toward Posix compatibility, which might include _close() and _fsync().
Unix and Posix file system semantics are not among the best achievements of the Unix philosophy or of Posix as a universal system interface, but they have been considered "good enough" by most for a long enough time to make an actually-good replacement increasingly unlikely to take hold.
What should you write,
? Or does it risk getting an infinite loop if, e.g., some network connection disappears?Maybe
But maybe fsync is interruptible too.Ultimately there is nothing strictly correct to write, and you should just not really count on files being closed before process termination, but call close() as an optimization not to leak too many fds.