News for hackers. Stuff that matters.

A comment on Facebook Down?. Parent comment

Re:Facebook Down? by londons_explore on Thursday April 08, 2021 @06:41PM (#26744709)
It would be hidden amongst a big refactor, and it would have a bunch of unit and integration tests that all work correctly (because they do set the environment variables correctly).

Writing code that appears to do one thing and actually does another is very doable - you only need to hide one malicious line amongst thousands in a code review, while the reviewer needs to inspect every line.

Besides, the vast majority of code reviews are 10 minutes or less.

[ Parent | on HN ]
Re:Facebook Down? by tracyhenry on Thursday April 08, 2021 @07:28PM (#26745034)
I think you oversimplified the code merge process at Facebook. Their internal code review system (Phabricator) would automatically add tens of reviewers to your PR because you changed an important script authored by those people. Also, there are linters that would call out the use of potentially hazardous commands. Actually deploying the thing is another process that requires jumping through a series of other review hoops.

p.s. I had a short internship there.

[ Parent | on HN ]