[off topic] I apologise in advance for the unsolicited review - I couldn't help it.

First, in service.api.api:43-49 you do:

    filename = (file.filename if file else None) or request.form.get("filename")
    [...]
    try:
        stored_metadata = storage.store(filename, file)

My understanding is you're receiving some file then storing it somewhere with the name provided by the client. That to me looks like a potential security issue. It looks like this function (what is this, Flask?) is both a view and a validator, yet it looks like the file name is not sanitised in any way. I would not accept all characters here. There are two problems: first is the name you use to save the file on disk. Think about e.g. slashes, dots, spaces and the non-printable characters. The other one is about access: if e.g. the file name contains "#" or other special URL character, the file might not be accessible at all.

Second, in service.api.api:54-55 you have:

    except storage.FileTooBigException as e:
        raise FileTooBig(str(e))

This masks the original exception. In order to avoid that, you have to tell the engine the new exception you're raising is the direct cause of some other exception:

    except storage.FileTooBigException as e:
        raise FileTooBig(str(e)) from e

It might not be that important with a client error like this, though. At worst it helps with debugging. [/off topic]

Hah, thanks for the review! Great feedback. This was a coding challenge from a few years ago when I applied for a gig at Zapier. It was time capped so I didn't spend any extra time making it perfect.

Note that in the screenshot there are yellow boxes around the `raise` keyword - this is a complaint from the linter to do exactly as you suggest.

    raise FileTooBig(str(e)) from e

I did not know this was possible. Thanks!

I, too, learned something new today even though I don't even pretend to be a Python developer!

I've been trying out Doom Emacs recently. I'll admit that I have used Vim and Emacs for reasonable periods of time previously so I am somewhat used to their way of doing things but Doom is nicely prescriptive and gives a great vim first experience. There is a bit of getting used to it but it might be something interesting for you.

> Doom is a configuration framework for GNU Emacs tailored for Emacs bankruptcy veterans who want less framework in their frameworks, a modicum of stability (and reproducibility) from their package manager, and the performance of a hand rolled config (or better).

This looks pretty neat.

I'd say the things to look out for are:

- Keybindings aren't comprehensively listed anywhere (that I know of)

- You have to go to the individual packages that are loaded and figure out how to use them

- There is some discoverability where if you type C-w you'll start to see all the window related keybindings, so you can at least get into the habit of checking there when you forget something

- I'm used to using C-c to return to normal mode in Vim which doesn't work here so my suggestion is to use C-[, jk or ESC I guess

- Autosave is disabled by default due to a preference of the maintainer, so you'll want to install a package or tweak the config to enable that

- I find window management difficult right now compared to something more conventional like VSCode or even compared to something like i3, it just doesn't seem to do what I want

Overall I'd say its like good guard rails but you'll probably need to dive into Emacs stuff to accomplish certain tasks. With that said, the vim emulation is miles better than what's available in VSCode.

There is also Spacemacs which aims to be much more comprehensive but I haven't tried that.

Hm, for a 4k screen, it has surprisingly little on the screen. Is the monitor pretty small (<32")?

I run scaled down slightly, it appears to me as 2560x1440 but still having the benefits of better pixel density.

FWIW I have an HP Z27 display which I adore. It uses a single usb-c umbilical cord to deliver power to my Macbook Pro ('18 touchbar model) and simultaneously video to the display.

The light that indicates whether the display is on or not is also incredibly small, the same size and intensity of the green 'webcam active' light on a Macbook, but in a white color.