News for hackers. Stuff that matters.
Re:Fundamentals of Optimal Code Style by Ankintol on Thursday March 25, 2021 @08:11PM (#26587346)
Does it look like I made a mistake to most people? I've never received a comment in a PR about it and I observe other developers using the same technique, so I'm surprised to hear this, do you feel very confident in this assessment? Just trying to gather feedback here.
Re:Fundamentals of Optimal Code Style by Leherenn on Friday March 26, 2021 @08:30AM (#26591279)
Maybe not a mistake, but code smell, often, yes. If you add blocks, it's usually because you want to group things together, and avoid scope leakage (if that's an issue, then you're probably doing similar things multiple times). Often a function will be a better fit here.