News for hackers. Stuff that matters.
Re:OpenSSL Security Advisory by saagarjha on Thursday March 25, 2021 @06:07PM (#26586133)
Using unwraps is often the “proper check”. Trying to come up with error handling in cases where invariants are not met is usually done wrong.
Re:OpenSSL Security Advisory by bluejekyll on Thursday March 25, 2021 @06:26PM (#26586382)
That's not a check at that point, though, it's an assertion that the None case is invalid.

I'm not saying you should never use unwrap, but I've been burned by it when treating it a little too nonchalantly. If you're implementing a lower level library, like a dns stub resolver, panicking will bring down the software using your library... which is definitely not something people are generally happy about.

Error handling isn't always the right thing, sometimes just returning Option is the correct thing.

Re:OpenSSL Security Advisory by ufmace on Friday March 26, 2021 @12:25AM (#26588727)
Yeah it may be valid, barring careful consideration of the exact situation. My canonical example is a web server.

In the context of handling a web request, never unwrap, because a web server should never die no matter what kind of weird or crazy thing a client somewhere sends it. Check every error for everything in that context, always at the very least drop back to a code path that returns a 500 and keeps the server running.

In the context of server init though, unwrap is good. If anything in the server init process goes wrong, that means I as the developer / deployment engineer did something wrong. The server should then blow up to let me know that something is very wrong and needs fixing. The server definitely should not try to rattle to life anyways and run in some sort of degraded state where it can't handle requests correctly.

Re:OpenSSL Security Advisory by richardwhiuk on Thursday April 01, 2021 @08:27AM (#26659569)
Usually `.expect` is better, as you can explain the error.