I get that these are in large part technically the fault of third-party developers, but it’s still pretty inconvenient as an end user to be unable expect to upgrade my OS without some major portion of my workflow being entirely non-functional for months.
Probably, but maybe not for the reasons you would think...
> so I had a credible "Works" style office suite (GoBe Productive)
Haiku has a LibreOffice port.
> a good text editor (Pe),
Pe is still around, or you can use Koder (a new Haiku-native app), Notepadqq, GVim, Kate, ...
> a good GUI mail client (Mail-It)
We have a few mail clients; the native one is alright but could use some work; there is also Trojita and some others like it.
> a surprisingly good object/bitmap hybrid graphics editor kind of like the old Macromedia Fireworks (e-Picture)
e-Picture has gone the way of the dodo (though you probably can still use it on 32-bit Haiku which has BeOS binary compatibility.) You can instead use WonderBrush (a native application), Krita, etc.
> The other problem I see is that most people have an existing laptop and want to try Linux on it, and run into hardware incompatibilities.
Yes, a thousand times. I ran into that more often than I would have expected just trying to get Linux to run in a VM on various Macs over the years, and once in a while on more recent PC hardware that I was trying to do something with. (Then I would write something that suggested Linux was still hard to install and people would argue with me. If it ever comes up again, I should definitely remember to add your caveat about existing hardware!)