There’s a lot of submodule haters out there. I think the majority of haters are people who tried to actually do work within submodules. That’s a recipe for conflicts. It’s probably best to go into the submodule directory, checkout a specific tag or commit, go up one directory, and commit.
This is a good blog post about submodule gotchas: https://www.jannikbuschke.de/blog/git-submodules/
Obviously there's a time and a place - if a language or build system I'm using includes dependency retrieval/resolution for projects, then that's usually my preference. But for things like C (and, currently, Zig) that lack such things, vendoring with git submodules is pretty nice.