Re:Mindsets to Avoid as a Senior Software Developer
by eithed on Tuesday March 02, 2021 @12:57PM
(#26318158)
I strongly disagree - while juniors are more than welcome to look at the PRs, if you allow juniors to approve PRs of other juniors you quickly find your codebase deteriorating.
[ Parent
| on HN ]
Re:Mindsets to Avoid as a Senior Software Developer
by apengwin on Tuesday March 02, 2021 @01:12PM
(#26318359)
That's not what they're saying. Srs. should still review jr. PRs. They're arguing that Jrs should also review Sr. PRs
Re:Mindsets to Avoid as a Senior Software Developer
by eithed on Tuesday March 02, 2021 @01:31PM
(#26318631)
Well, if you'll allow everybody to review everybody PRs then eventually that's what you'll get.
Similarly - junior might look at your PR and see that it's ok. Senior might look at it, see that you've forgot about a thing that junior didn't know about, you omitted to test a certain condition, etc.
Again, juniors are more than welcome to look at PRs and be a part of discussion, but if you're merging, you should be wary. I'd personally be against allowing a merge if you get only a junior approval.
Re:Mindsets to Avoid as a Senior Software Developer
by CodeMage on Tuesday March 02, 2021 @01:49PM
(#26318849)
> Well, if you'll allow everybody to review everybody PRs then eventually that's what you'll get.
If you allow everybody to review every PR, it doesn't imply that you'll allow everybody to approve every PR.
Re:Mindsets to Avoid as a Senior Software Developer
by lowbloodsugar on Tuesday March 02, 2021 @01:44PM
(#26318782)
The difference is "approve" vs "criteria for merging". We have a system that requires two approvals, but one must be from a list of seniors (which doesn't include new hires).