No one is forcing you to upload your music to the iCloud. You can keep syncing it the same way you always have (afaict, anyway).
No one is forcing you to buy an iPhone, iPad, or any other Apple product. What kind of lock-in are you on about?
No one is even forcing you to upgrade to Lion. Keep running Snow Leopard if you want.
If you don't like it, don't buy it. There are plenty of other vendors. The only way in which you could claim that Apple was "locking people in" is that they offer an integrated experience, so that if you go all-Apple, things work better.
Well, damn them, they should be shot! How dare they try to offer an integrated user experience to their paying customers? What bastards!
If you don't like it, don't buy it.
That's not what vendor lock-in is about. Lock-in means that after you bought it, you can't reasonably switch to something better, something that commonly you didn't know about or that didn't exist when you made the initial buy. For example, when offering integrated services, lock-in might mean that they won't allow a third party to integrate with their suite.I guess car makers practice vendor lock-in too by your definition.
In fact, almost anyone who sells something practices some form of lock-in.
And yes, mild lock-in is very common. That doesn't make it a good practice from the consumer's point of view.