This announcement seems great. I will get way more than $25/yr value out of having reliable access to all this music again.
I am not hung up on "how often" I've paid for this music. I bought the CDs; if I wanted to, I could have archived them as carefully as Rob from High Fidelity. I have better things to do with my life. The $25 convenience fee here is buying me a lot of convenience.
If I didn't want the convenience, I wouldn't have to pay for it. I could just rerip. Let me work out my hourly rate and see what kind of return I'm getting for nevermind I'm just going to pay Apple.
This is for people with existing collections of questionable legality or other provenance, who otherwise wouldn't join the service if it meant they had to give all that music up.
2. Apple doesn't live in a vacuum and isn't stupid, they know they're effectively offering amnesty to pirates. Their bet is that they win by bringing people into their ecosystem, that $25 and a shot at future purchases is a better deal than the nothing they're currently getting from pirates.