News for hackers. Stuff that matters.

A comment on Git is my buddy: Effective Git as a solo developer. Parent comment

Re:Git is my buddy: Effective Git as a solo developer by w0mbat on Wednesday February 24, 2021 @05:49PM (#26257244)
I hate this. Often I am rewriting a bad comment, or improving the working code I checked in yesterday whose ticket has already been closed. Deleting an unneeded #include. All kinds of stuff for which there is no open ticket.

This kind of rule prevents people from maintaining the code base as they go. I have literally quit a company because of bullshit such as this. I was a senior engineer and could not fix a typo in a comment without a bug number and two code reviews.

[ Parent | on HN ]
Re:Git is my buddy: Effective Git as a solo developer by SilverRed on Wednesday February 24, 2021 @09:28PM (#26258997)
This has been a non issue for me. I just slap minor fixes in with other tickets even if they are not related. Usually I just drop a comment in the review page with "saw this other issue and fixed it"

Short circuiting the review and QA steps is not ideal. A reviewer should see the change is just a comment typo fix and accept it even if it has nothing to do with the current ticket.

[ Parent | on HN ]