Re:Python’s tug of war between beginner-friendly and advance...
by ianhorn on Thursday February 04, 2021 @09:28PM
(#26032354)
A super common solution to the problem of too many ideas packed into a clever solution is just naming intermediate things. For example, naming the zip(...) is a little change that goes pretty far in making the second one more obvious:
or even naming the width generator:
Same thing, just with more built in explanation. It's easy to go overboard, of course, but it's a useful go-to to make stuff more obvious.
[ Parent
| on HN ]
Re:Python’s tug of war between beginner-friendly and advance...
by michaelhoffman on Thursday February 04, 2021 @10:05PM
(#26032588)
Whitespace helps too! And I think using `sorted(key=)` is more Pythonic than a generator expression ;)
from operator import itemgetter
def maxWidthOfVerticalArea(self, points: List[List[int]]) -> int:
xs = sorted(points, key=itemgetter(0))
x_pairs = zip(xs, xs[1:])
widths = (right-left for left, right in x_pairs)
return max(widths)
NumPy also has stuff to solve this sort of thing built-in: from numpy import diff
def maxWidthOfVerticalArea(self, points: List[List[int]]) -> int:
xs = sorted(points, key=itemgetter(0))
widths = diff(xs)
return widths.max()
Re:Python’s tug of war between beginner-friendly and advance...
by ianhorn on Friday February 05, 2021 @02:22AM
(#26033950)
For the last bunch of years, wherever my instinct says to add white space, I instead put a comment. If you want something to be a visually separate entity, it’s the perfect place to put a couple words about that entity, and it still gets the visual separation in an editor with any syntax highlighting at all.
Re:Python’s tug of war between beginner-friendly and advance...
by roelschroeven on Friday February 05, 2021 @05:34AM
(#26034880)
> And I think using `sorted(key=)` is more Pythonic than a generator expression ;)
But it doesn't do the same thing. The original code extracted the xs from the coordinate pairs, sorted; your code sorts the coordinate pairs by their x values, but doesn't extract the xs from them.
Re:Python’s tug of war between beginner-friendly and advance...
by michaelhoffman on Friday February 05, 2021 @01:01PM
(#26039236)
Oops! Good point! Unfortunately too late for me to edit.