News for hackers. Stuff that matters.
Re:Todo List for Vim by djoldman on Tuesday January 26, 2021 @06:31AM (#25914620)
I think what parent is implying is that it is difficult to get a commit past Bram Moolenaar.
Re:Todo List for Vim by widforss on Tuesday January 26, 2021 @07:27AM (#25915046)
I did a PR regarding some rarely-used setting a couple of years ago, as part of a uni course in architecture. It wasn't merged immediately as I didn't write tests for it, but Moolenaar wrote the tests himself later, and merged it.

https://github.com/vim/vim/pull/3539

https://github.com/vim/vim/commit/375e3390078e740d3c83b0c118...

Re:Todo List for Vim by monkin on Tuesday January 26, 2021 @06:45AM (#25914709)
I see huge amount of PR merged with VIM on daily basis send by other people.

I think that every open source project used by thousands of people should have person like Bram. Who will draw a line and separate low quality or effort PRs. Many hate it and call them dictators, but that's just taking care of your own project, and keeping it at the highest standard.

Re:Todo List for Vim by ruph123 on Tuesday January 26, 2021 @06:50AM (#25914754)
I think no open source project should have a maintainer who answers the question of how to make the project succeed in the future with:

“Keep me alive” [1]

[1] https://www.binpress.com/vim-creator-bram-moolenaar-intervie...

Re:Todo List for Vim by Veen on Tuesday January 26, 2021 @07:00AM (#25914818)
That's what is technically known as "a joke".
Re:Todo List for Vim by jwatt on Tuesday January 26, 2021 @07:36AM (#25915122)
I took a quick look at the contributor graph:

https://github.com/vim/vim/graphs/contributors

Other than one solitary commit, that graph makes it look like every single one of the 13,000 commits to Vim has been made by Bram. What's going on there?

Incidentally I wondered what caused the huge jump in commits that has been sustained since the beginning of 2016. I thought initially that may have coincided with the announcement of Neovim, but that announcement seems to have been a couple of years earlier. Maybe it took a couple of years for Neovim to see significant adoption though.

Re:Todo List for Vim by monkin on Tuesday January 26, 2021 @07:43AM (#25915168)
Patches are send to mailing list, and Bram commits them do repository after review. Each contribution is credited in commit message, and VIM docs.

I like this approach better than GitHub “everyone send us a PR”. These days having a “change a typo” PR to show activity on GitHub is appealing to masses, but mailing list sifts out people who don’t have anything serious to add = less work in managing open source project. As we can see lot’s of maintainers have a problem with that, and users that demand stuff (at least once a month there’s a topic about it on HN). :-)

Re:Todo List for Vim by jwatt on Tuesday January 26, 2021 @08:17AM (#25915429)
Thank you. Having a mailing list based workflow is fairly common for long established projects. That doesn't seem to preclude setting the Author field to the actual author when Bram lands people's contributions though. Unless that's an additional layer to discourage low value contributions by eliminating the visible credit people would get in their github commit history. Are there other projects that do that?
Re:Todo List for Vim by monkin on Tuesday January 26, 2021 @08:34AM (#25915566)
As I mention before, each of contributions is credited on GitHub commits, and VIM docs. So you still can showcase those in your portfolio, by writing case study or short information as it was before GitHub... :-)