It is very much legal to threaten the President. You might get a visit from the Secret Service if your threat is deemed credible enough, but otherwise, threatening the President is exactly the same as threatening anyone else (actually perhaps even less likely to result in sanction: I could eventually accuse you of harassment for repeatedly making threats against me, the President likely cannot).