News for hackers. Stuff that matters.
Re:Sony publishes an official Linux driver for Playstation 5... by pizza234 on Friday December 25, 2020 @05:43AM (#25535670)
I spent to some time to check and analyze the code.

The author uses it in a clear pattern, specifically, as a sibiling post mentions, in order to achieve error handling (additionally, with fall-through); the labels are indeed neatly placed at the end of the function, after the `ret` exit.

The problem is consistency - the upper half of that function performs error handling without goto, and the lower half with it.

I personally prefer all-or-none solutions, since I highly value consistency, but on the other hand, I do consider this solution acceptable, since it still has a tidy (enough) structure.

There are no comments on this comment yet.