Re:What Every C Programmer Should Know About Undefined Behav...
by ramidarigaz on Thursday May 12, 2011 @12:23PM
(#2541124)
If the compiler can optimize that away, what's the proper method for checking p?
[ Parent
| on HN ]
Re:What Every C Programmer Should Know About Undefined Behav...
by panic on Thursday May 12, 2011 @12:39PM
(#2541212)
Check p before using it. The issue is when you have code like the following, where the behavior of the first statement is only defined when the condition in the second is false:
int x = *p;
if (p == NULL) {
// p can't be NULL without having triggered
// undefined behavior in the first line, so
// this code is removed by the compiler.
return;
}
// ...
The fix is to stop dereferencing p before you know whether it's NULL or not: if (p == NULL) {
// Moving the check before the dereference
// avoids undefined behavior and resolves
// the issue.
return;
}
int x = *p;
// ...