Re:How to Make Your Code Reviewer Fall in Love with You
by lmilcin on Tuesday December 08, 2020 @05:53AM
(#25343799)
Yeah... I have a lot of that discussion with my team, too.
It seems people (reviewers) need to find something or they think they are not doing good job.
Another irritating practice is treating opinions about style as commands -- basically commanding the author to change the style of the code to conform to the reviewer.
It should be understood that every problem has many potentially correct solutions. The job of the reviewer isn't to assure the best correct solution or the solution they like, it is to verify that the one selected by author is in the set of correct solutions. If this makes sense...
It seems people (reviewers) need to find something or they think they are not doing good job.
Another irritating practice is treating opinions about style as commands -- basically commanding the author to change the style of the code to conform to the reviewer.
It should be understood that every problem has many potentially correct solutions. The job of the reviewer isn't to assure the best correct solution or the solution they like, it is to verify that the one selected by author is in the set of correct solutions. If this makes sense...