How to Make Your Code Reviewer Fall in Love with You

Re:How to Make Your Code Reviewer Fall in Love with You by microtherion on Monday December 07, 2020 @02:32PM (#25336109)

I was going to say something similar.

When I'm the reviewer, I try to decided for myself whether something is truly important, or just a style choice. If it's the latter, I will comment on it, but then add "Your call." to make it clear that I expect ties to go to the author.

[ Parent | on HN ]

Re:How to Make Your Code Reviewer Fall in Love with You by _greim_ on Monday December 07, 2020 @02:41PM (#25336255)

This should be included in a "How to Make Your Code Reviewee Fall in Love with You" companion article, if one doesn't exist yet.

[ Parent | on HN ]

Re:How to Make Your Code Reviewer Fall in Love with You by mtlynch on Monday December 07, 2020 @08:02PM (#25340166)

I wrote a list of code review suggestions a few years ago that focus on things the reviewer should do:

https://mtlynch.io/human-code-reviews-1/

[ Parent | on HN ]

Re:How to Make Your Code Reviewer Fall in Love with You by randomswede on Tuesday December 08, 2020 @03:25AM (#25343127)

I wrote a "what makes for a good change" doc a while ago, that touches on this.

https://github.com/vatine/sressays/blob/master/change-reques...

[ Parent | on HN ]