News for hackers. Stuff that matters.

A comment on How to Make Your Code Reviewer Fall in Love with You. Parent comment

Re:How to Make Your Code Reviewer Fall in Love with You by bird_monster on Monday December 07, 2020 @12:09PM (#25334129)
I have a rule that if stylistic decisions matter enough to reject a PR over, they also have to be enforced by a linter or code formatter. If they are that big a deal, we should enforce them via automation, not review. And if they're not that big a deal, do not put them in a code review.
[ Parent | on HN ]
Re:How to Make Your Code Reviewer Fall in Love with You by Tade0 on Monday December 07, 2020 @12:32PM (#25334448)
It baffles me that this isn't the consensus.

I've waged wars over documenting styling rules (some too complicated to be covered by a formatter - which by itself is a red flag) because I know that people often forget to enforce rules that they themselves have come up with.

[ Parent | on HN ]