Re:So you've made a mistake and it's public
by vonseel on Friday November 13, 2020 @04:11PM
(#25087547)
Yea, unless you're professional writers, and I don't mean coders, that's not the right kind of things to focus on in pull requests. I mean, if someone happens to be great at code but really terrible at English, like you can't imagine they passed high school grammar, maybe it's a good idea to help them improve. But the average college educated developer writes well enough to write succinct and readable code comments and documentation. Or should be able to.
Re:So you've made a mistake and it's public
by mixmastamyk on Friday November 13, 2020 @05:31PM
(#25088337)
Even when we learn from a mistake it may still happen in the future. Hopefully we have reduced its frequency but it can still happen.
For example, I sometimes write "too be honest…". I've known it is wrong for decades, but occasionally am still not able to see it. Still happens about one out of every fifth time.
I recently pointed out to a different coworker some whitespace inconsistency in a pull request in a similar fashion as I had pointed out a while back.
In digging deeper into both situations where I was the reporter or the reportee, the issue came down to legitimate lack of agreement on whether it was indeed a mistake.