News for hackers. Stuff that matters.
Re:Hosting Provider Leaked 63M Records Including Magento and... by formerly_proven on Thursday November 05, 2020 @09:18AM (#24998387)
> Way too verbose logging. Should never have logged that.

It's interesting to observe the contrast between this and "We're a SaaS startup and we log every.single. RPC request across all services forever including performance data".

Re:Hosting Provider Leaked 63M Records Including Magento and... by user5994461 on Thursday November 05, 2020 @10:19AM (#24998952)
You can log all HTTP requests and it is standard practice to do so at the load balancer level (haproxy and co have very configurable logging).

However you MUST NOT logs cookies or headers or content, because these can contain private information.

Last but not least, developers should never pass tokens/passwords in the request path because it will be systematically logged and leaked /api/token/abcdec. That should go into a header or the body.

Re:Hosting Provider Leaked 63M Records Including Magento and... by happy_pancake on Thursday November 05, 2020 @10:26AM (#24999027)
Single-used tokens are fine to be passed in the path right? Like email verification /token/{token}
Re:Hosting Provider Leaked 63M Records Including Magento and... by tialaramex on Thursday November 05, 2020 @07:57PM (#25003804)
For email verification it's less scary if that was really all you wanted.

If you believe you're verifying that the email went to your user, this isn't enough. Lots of systems parse URLs out of emails and follow them, you probably want to look for a a pre-existing session cookie, or insist the user log in from the verification page and confirm this is what they wanted.

Otherwise you've merely got two unrelated facts:

1. Some user of your system (maybe happy_pancake) says [email protected] is their email address

2. Mail to [email protected] is received by a machine or person which reads web pages.

It would be foolish to conclude from these facts that happy_pancake is actually [email protected] or that [email protected] wants to use your service.

Re:Hosting Provider Leaked 63M Records Including Magento and... by stonemetal12 on Thursday November 05, 2020 @04:09PM (#25002004)
Defense in depth says No, not Ok.

For example: Accidentally open to the internet log server(as above). Attacker sends password reset request. Attacker checks log to steal token. Attacker now has stolen account until owner can't log in and does reset, or perhaps semi-permanently if attacker steals all tokens for said account and invalidates them before owner can use them.