News for hackers. Stuff that matters.
Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by rurban on Monday October 12, 2020 @02:58AM (#24752069)
The opposite. The lack of abstractions, mere industrial copy pasta code is the problem.
Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by andy_ppp on Monday October 12, 2020 @03:55AM (#24752323)
I’m not saying it’s true here but duplication over the wrong abstraction is always better. Seems to me if each graphics card is different enough there’s probably lots to duplicate.
Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by VBprogrammer on Monday October 12, 2020 @05:08AM (#24752644)
In software development absolutes are always dangerous.
Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by andy_ppp on Monday October 12, 2020 @05:19AM (#24752702)
Apart from absolutes about absolutes.
Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by rurban on Thursday October 15, 2020 @06:19AM (#24786905)
Nonsense. This duplication is not maintainable and needs massive amounts of memory. Proper abstraction adds a few if else in the data, and is about 20x smaller. You can even read and understand that, e.g. what changed with this HW upgrade. No chance with duplicated blobs of structs and enums.
Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by andy_ppp on Thursday October 15, 2020 @08:39AM (#24787943)
> I’m not saying it’s true

Yes, I did caveat my suggestion. Why not submit a fix if it's so simple ;-)

Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by mrweasel on Monday October 12, 2020 @06:36AM (#24753079)
If the Radeon driver is in the kernel now, then maybe at some point someone other than AMD will pick it up and start cleaning up excessive copy paste code.

Assuming they play nice with the community, it could be a huge benefit to AMD in the long run.

Still, 2 million lines is a massive amount of code to start working on.

Re:The AMD Radeon Graphics Driver Makes Up Roughly 10.5% of ... by samus on Thursday October 15, 2020 @01:54AM (#24785313)
Unlikely, unless that entity has all the supported hardware at hand and ready for automated tests. Refactoring without a thorough test harness is ref*toring.