> is perfectly valid C++
we're in 2020.
$ clang-tidy -checks='cppcoreguidelines-*' foo.cpp
/tmp/foo.cpp:10:3: warning: initializing non-owner 'Thing *' with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory]
Thing* thing = new Thing();
^
/tmp/foo.cpp:12:3: warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead [cppcoreguidelines-owning-memory]
delete thing;
^
/tmp/foo.cpp:10:3: note: variable declared here
Thing* thing = new Thing();
^Does it compile? Does it run? Yes, therefore it's valid C++.
I'm not arguing it's good C++, but saying "C++'s destructor behaviour doesn't work if you don't use C++" in relation to using new and delete is clearly nonsense.
Re:C++ the Good Parts (2014)
by umanwizard on Tuesday October 06, 2020 @08:40PM
(#24704141)
The malloc/free version is perfectly valid C++ too, isn’t it?
Eh... kind of?
I guess it depends on your definition of "valid".
Let's say we have:
class Thing
{
public:
Thing() { cout << "created" << endl; }
~Thing() { cout << "destroyed" << endl; }
};
Assuming the happy path, the new/delete version will be functionally identical to a more correct/idiomatic {
auto thing = make_unique<Thing>();
}
The malloc/free version won't call the destructor, and therefore doesn't do what a "normal" object would do.It's splitting hairs, I guess, but that's where I'd draw the line.
If, OTOH, you do
the you fully deserve the inevitable world of pain that is coming your way