News for hackers. Stuff that matters.
Re:I review code for a living and these are my most common r... by stevesycombacct on Tuesday September 08, 2020 @02:37PM (#24411439)
One bit of feedback on "3. Mutating values"

The reason that

    _ = [validations.pop(key) for key in ('executed','filter_type')]
     
is a mutation is because of the .pop() command, which the article didn't state. .pop() removes items in-place, thus mutating the data. Since the function doesn't make a copy of the dictionary, the original variable gets mutated.

This may confuse those wondering what the difference between the two functions is.

Otherwise, I find the article's points reasonable.

There are no comments on this comment yet.