I agree with your point about diversity beyond ethnicity and race in some regards. I 100% agree schools should try for more income diversity for example. However other criteria you listed are meaningless. I don't see a benefit to height diversity or ugliness/beauty diversity. Other examples of yours also serve to conflict with your first point. There are some people who get rejected from Yale who would otherwise get into Yale if they could play basketball well or if their parent attended Yale. Is that discrimination against those people? I tend to think not. Treating everyone exactly the same isn't always the fairest solution in every situation.

Also your NBA example doesn't fit because it clearly falls into the category when you need the top X basketball players. I don't think needing the top X students is or should be the goal of college admissions. The goal of a basketball team is to defeat other teams in competition. It is inherently a zero sum game. The goal of a university is to educate the population. It is not a zero sum game and having a diverse student body actually works to support that goal.