News for hackers. Stuff that matters.
Re:Raphters, a web framework for C by rbranson on Monday April 04, 2011 @01:38PM (#2407580)
This is neat.

Honestly, in addition, I'd like to see something like Rack for C. The "gateway interfaces" for C are too implementation-specific (CGI, FastCGI, SCGI, web server extensions/modules, etc). It would be something more abstract that would run on-top of a web server interface.

     void application_main(web_request *request, web_response *response)
     {
          char body[1024];

          snprintf(body, sizeof(body), "Hello, %s", request->param("username"));

          response->status(200);
          response->header("Content-Type", "text/html");
          response->write(body);
          response->end();
     }
Re:Raphters, a web framework for C by tptacek on Monday April 04, 2011 @02:58PM (#2407977)
As an illustration of why C kind of sucks for web apps, that code is obviously insecure† (it's reflected XSS). To get around that while preserving natural syntax, you want:

  char *hsafe(const char *input);
But where does hsafe get the memory for the string from? It can't use input (the filtered result is larger than the input). Does it malloc? Now you have to free the result. Does it do the inet_ntoa() thing with the static variable? Now you can't chain it (or use threads, but you wouldn't want to do that anyways).

Maybe you can do an arena for each connection, so it's:

  char *hsafe(request_t *r, char *str)
But that's still sort of painful.

† In an admittedly artificial way.

Re:Raphters, a web framework for C by crux_ on Monday April 04, 2011 @09:26PM (#2409307)
I think part (far from all!) of the issue is that you (and parent) are not using the right abstraction: The response body shouldn't be a string; it should be a stream:

   write_quot(response,"this < should be safe >");
   
Not perfect (you still need to deal with allocating temporaries if you want to inspect the contents before sending to the client), but: it (a) matches what's actually going on under the hood, (b) makes the simple cases safe, (c) provides a decent interface for safely extending the available formatters. (They would write their output to the stream, then free all temporary resources themselves before returning.)

(Further, I've had enough influence from statically-typed-land that I'd personally want to create tainted wrapper structs so that the compiler helps prevent user data from being passed to an unquoted write... but that's just me.)

Re:Raphters, a web framework for C by nkurz on Monday April 04, 2011 @04:17PM (#2408323)
I'm not seeing this a problem with C, but perhaps I misunderstand. Your goal is avoid including anything executable in the page. The filtered result is only larger than the input if you need the ability to faithfully quote the potentially malicious code. In this particular contrived example, you could "just" strip it out and make it shorter, or even error out if you see anything suspicious.

Which is to say it's only a problem if you are doing it by hand on a per field basis. Which leads to your next point:

  >  Maybe you can do an arena for each connection, so it's:
  >  char *hsafe(request_t *r, char *str)
  >  But that's still sort of painful.
This is only painful if you are doing it by hand every time you use the parameter. If the framework handles it for you, so that you always get the sanitized result, it strikes me as no different than any other language.

r->param("input"); // presanitized, lazily created, pooled in r

r->param_raw("input"); // if you want to live dangerously

Why is this worse in straight C than in something like Python that is doing the same thing but with an interpreted layer between you and the C?

Re:Raphters, a web framework for C by tptacek on Monday April 04, 2011 @04:47PM (#2408451)
You need to convert < into &lt;. That's the price of entry. You can't redefine the problem to "web framework that simply strips < out of inputs". Your framework would then be immediately inferior to every other framework which does output quoting.
Re:Raphters, a web framework for C by nkurz on Tuesday April 05, 2011 @02:38AM (#2409973)
Yes, if it was done in the framework, you'd want to have the sanitizing and allocation happen seamlessly, and you'd want the memory management to be simple as well. My confusion was why this strikes you as a significant difficulty for a framework author to set up.

Certainly it's harder if you decide that you are going to work from the ground up in straight ANSI C, but there's lots of good pool memory allocators out there. I'd either use one I had laying around, or just link in the one from the Apache Portable Runtime: http://apr.apache.org/docs/apr/1.4/group__apr__pools.html

The framework author could easily hide this behind the scenes, so that the user would find the string creation and destruction just as seamless as in Perl or Python. Use it and forget it, and the pool would be freed along with the Request. Thus my question, and my confusion, was why you finished with "But that's still sort of painful."

Re:Raphters, a web framework for C by wladimir on Tuesday April 05, 2011 @07:43AM (#2410518)
Hm good point. Built-in C string handling is much too painful for me to even consider doing a web application in C, and you have to worry about buffer overflows and memory leaks all the time. I'm so happy I don't have to do that in Python.

Then again, if you have a sane string handling library in C instead of messing around with strcpy/strcat, malloc/free and fixed-sized buffers, I guess it could be made more convenient.

so that the user would find the string creation and destruction just as seamless as in Perl or Python

If you manage to do that, please send me the link :)

Re:Raphters, a web framework for C by DanWaterworth on Wednesday April 06, 2011 @12:23PM (#2415726)
You could just have a linked list of memory allocations that get freed at the end of the request.
Re:Raphters, a web framework for C by JoachimSchipper on Monday April 04, 2011 @04:23PM (#2408347)
If you're going for clean syntax, you could store an arena pointer in a global variable/thread local storage (depending on the programming model). Just make sure the scaffolding switches/creates/destroys the arenas. I think you'd still want a hierarchical allocator, though.
Re:Raphters, a web framework for C by sigil on Monday April 04, 2011 @02:08PM (#2407730)
> The "gateway interfaces" for C are too implementation-specific (CGI, FastCGI, SCGI, web server extensions/modules, etc). It would be something more abstract that would run on-top of a web server interface.

Yes. My preference in web apps (esp in C) is also to deal directly with http requests and responses. Although I wouldn't necessarily call that the "more abstract" approach. To an extent, each of these gateway interfaces is a different leaky abstraction for http.

Re:Raphters, a web framework for C by roel_v on Monday April 04, 2011 @01:43PM (#2407620)
Rather:

    response_set_status(200);
    response_set_header("Content-Type", "text/html");
    response_write(body);
    response_end();
The awkwardness of which, to me, demonstrates the superiority of C++ in this regard.
Re:Raphters, a web framework for C by jerf on Monday April 04, 2011 @02:00PM (#2407721)
That implies some global state somewhere being updated, and now you've given up on threading. This may be OK, but it's still dangerous and leaky even if you give up on threading.

There are various solutions that still allow you to pass a set of closures without being particularly more ugly than anything else is in C, for instance, see http://library.gnome.org/devel/gobject/stable/chapter-signal... . C++ still ends up nicer, my point is just that you can do good things in C and there are libraries that implement the stuff for you.

That said, if I were really going this route I probably would try to go with some sort of minimal C++. Then again, my opinion is suspect, as I would never go this route anyhow. Web developers writing in languages that don't permit buffer overflows write software that has all the security of a colander; adding the ability to write good, solid buffer overflows as well hardly seems like a step up. You can write secure C code, but you can write secure PHP code, too. Existence proofs of secure code aren't very interesting.

Re:Raphters, a web framework for C by DanWaterworth on Monday April 04, 2011 @02:19PM (#2407788)
You're right, web developers already write software with all the security of a colander. You can go one of two ways, 1.) you can devise a language that can't express an insecure application or 2.) you can teach people about security. I know which option I prefer.
Re:Raphters, a web framework for C by tptacek on Monday April 04, 2011 @02:49PM (#2407933)
Overly reductive. There is an actual security benefit to using environments that minimize memory corruption. Educating devs helps, but educated devs do not reliably avoid memory corruption.
Re:Raphters, a web framework for C by jerf on Monday April 04, 2011 @02:49PM (#2407931)
I assume you mean #2? Because here we are in year, oh, 17 or 18 or so of web development give or take a couple of years and that's worked out so well, hasn't it?

It's a beautiful sentiment. It hasn't worked. Handing them new vectors to screw up in is not going to solve the problem.

It also doesn't matter. Hand a developer a tool that requires them to continuously pay attention to an issue and no matter how good they are, at some point they will slip, because they're human. We've tried "teach them about security" a couple hundred times, maybe it's time we try "devise a language that can't trivially express an insecure application". C will not be the language that implements that, it completely lacks any of the necessary primitives, by design.

Re:Raphters, a web framework for C by adambyrtek on Monday April 04, 2011 @05:24PM (#2408604)
Web applications vulnerable to shell-code injection... this sounds like a security nightmare.
Re:Raphters, a web framework for C by bdonlan on Monday April 04, 2011 @02:48PM (#2407928)
They don't have to be global state - they can be updating thread local state, for example, in what is essentially dynamic scope. Depending on the OS, the efficiency of such TLS accesses can be quite good - on Linux, for example, it's just an extra pointer indirect or two with a segment selector (assuming the code is statically linked; it's very slightly more expensive in a solib).
Re:Raphters, a web framework for C by jerf on Monday April 04, 2011 @02:50PM (#2407937)
Touche. It's still an API design that's going to prove problematic, though.
Re:Raphters, a web framework for C by tptacek on Monday April 04, 2011 @02:48PM (#2407926)
You're only a couple function pointers away from the syntactic sugar of the -> operator.
Re:Raphters, a web framework for C by rbranson on Monday April 04, 2011 @01:51PM (#2407670)
Yeah that's what I get for being in the OOP world for the daily grind. I think a C API is still definitely for the best. Perhaps a nice shortcut API for this would be something like:

    response_complete(200, body, response_header("Content-Type", "text/html"));
Re:Raphters, a web framework for C by roel_v on Tuesday April 05, 2011 @03:51PM (#2412432)
Well yes it should have been

    response_set_status(handle, 200);
My point was that the syntax in the example was C++.
Re:Raphters, a web framework for C by VladRussian on Monday April 04, 2011 @04:51PM (#2408461)
in correct functional style shouldn't it rather be :

response_set_status(response, 200);

no issues with global state, threading (if correctly mutexed), etc...

Re:Raphters, a web framework for C by rubashov on Monday April 04, 2011 @08:41PM (#2409217)
All the pieces to do the whole framework are already in POCO and other libraries, with ssl and cookies etc.

http://pocoproject.org/docs/Poco.Net.HTTPResponse.html

http://pocoproject.org/docs/Poco.Net.html

Doing this in C seems silly to me.

Re:Raphters, a web framework for C by rch on Monday April 04, 2011 @04:28PM (#2408376)
You might look here before starting from scratch in C: http://okws.org (C++)
Re:Raphters, a web framework for C by DanWaterworth on Monday April 04, 2011 @01:50PM (#2407661)
It would be possible to support other gateway interfaces in raphters. The abstractions already exist.