Re:Hacking up a fix for the broken AppleTalk kernel module i...
by saagarjha on Saturday August 01, 2020 @10:30PM
(#24025842)
In general, a lot of contribution workflows are fairly daunting to newcomers–when I tried to submit a fairly small patch to the Linux kernel it took me a while before I figured out what to do, and even then I messed it up and it didn't end up going in. (Full disclaimer: I commented about it here and someone was extremely kind in sending me resources on how to actually do this. I haven't yet followed that advice, sorry!) But even with this, it's still really complicated to figure out how each project does things. I understand many don't really care about one-line patches, but it would be nice if this kind of thing (which I personally consider "outreach") was better supported.
Re:Hacking up a fix for the broken AppleTalk kernel module i...
by tyingq on Saturday August 01, 2020 @10:44PM
(#24025893)
Bravo. Sometimes those one-line patches are gold. I still use a one-line patch for a popular Perl serial/rs-232 module that some kind soul tried to contribute, but failed to get accepted. It's been that way for 10 years or so.
Re:Hacking up a fix for the broken AppleTalk kernel module i...
by saagarjha on Saturday August 01, 2020 @10:55PM
(#24025948)
I have heard the other side, which is that many one-line patches require significant time from maintainers because it's often "hand-holding" to get them to where they need to be and often they are not really correct or have some other issues. But even with that I think the case of "maintainer abandoned this patch" or "maintainer is actively looking for new contributors but does not make it easy to get your foot in the door" is the more common one.
Re:Hacking up a fix for the broken AppleTalk kernel module i...
by jon-wood on Sunday August 02, 2020 @09:30AM
(#24028576)
When submitting a pull request upstream on GitHub there’s the option (I believe enabled by default) to allow members of the upstream repository to push to your branch, presumably for just this reason of it needing a few tweaks.
I get there are opposite examples of contributors just being contrary and rude, but some sort of workflow to quickly make good, but standards-flawed fixes compliant has merit.
Your idea of a simple way to let someone else take over a pull request seems good.