Re:GitHub Super Linter: one linter to rule them all
by waheoo on Thursday June 18, 2020 @10:49PM
(#23570494)
Thats what im talking about. If you add text to a line, and it goes over a length, it will reformat a jsx element into about 5 lines instead of 1. Similarly, when you add more than it needs because you want consistency, or know youll add more, and the formatter runs, often it undoes your work.
Re:GitHub Super Linter: one linter to rule them all
by tlrobinson on Friday June 19, 2020 @01:40AM
(#23571341)
Prettier lets you control object literal formatting by inserting/removing the newline after the opening brace, I'm not sure why they don't do that for JSX elements.
https://prettier.io/docs/en/rationale.html#multi-line-object...
Re:GitHub Super Linter: one linter to rule them all
by earthboundkid on Friday June 19, 2020 @12:14AM
(#23570906)
If you really want 5 lines, add a dummy // in there and will be forced to use 5 instead of 1. Dirty hack, but it works.
Re:GitHub Super Linter: one linter to rule them all
by vages on Friday June 19, 2020 @02:22AM
(#23571572)
That, or a prettier-ignore comment above the JSX tag. I find your solution more elegant, though.
My two cents: Write the comment's purpose inside it. "// Comment inserted to force prettier line break until more attributes are added"
Re:GitHub Super Linter: one linter to rule them all
by waheoo on Saturday June 20, 2020 @11:11PM
(#23589435)
Im talking about adding an attribute in the next 5 minutes, no, im not going to add a comment, or an ignore line while im editing a component. Those are really awful work arounds to a man made problem.
Re:GitHub Super Linter: one linter to rule them all
by libria on Thursday June 18, 2020 @11:36PM
(#23570690)
It's tunable. Pick a line length you all agree on and when it reformats after that, that's what you asked for.
If the rule never works for you, turn that one off.
If the rule is what you want 99% of the time but it made this one line look dumb, mark that one block #ignore and let the team decide in CR if that was the right call.
What you're missing here is that you're supposed to be using it all along, all the time. Format on save. Format on commit. Format on server pipelines. Format all the time. It can never 'undo' anything if it's what's providing the formatting in the first place.