Re:Ask HN: feedback on an idea - code reviews site
by ScottWhigham on Tuesday March 22, 2011 @08:15AM
(#2353979)
I'm trying to figure out how the scheduling would work. Let's say I have a dev team of five people and we decide to do what you've suggested. We work today from 10AM-8PM. Here's where I have an issue: do we (or "do you expect people to") wait to code more until we've received feedback? Or do we keep coding without waiting?
If it's the former, then are there going to be enough quality code reviewers from 8:01PM - 9:59AM so that our workflow wouldn't be affected? It most certainly would require a bunch of mostly-overseas coders to review code during those hours. That means to make this "work" you need global marketing - not impossible, just more work.
If it's the latter, then I wonder what people will do when a comment is posted on code that is 7 days old? Many times I've written lines and lines of unit tests, integrated the code into many different areas, and moved on into another area/module. A minor refactoring would take us out of our current workflow and be costly. A major refactoring may cause us to delay launch. If the refactoring is high quality it would be worth it. So the key here is finding code reviewers who contribute high quality refactoring ideas.
If it's the former, then are there going to be enough quality code reviewers from 8:01PM - 9:59AM so that our workflow wouldn't be affected? It most certainly would require a bunch of mostly-overseas coders to review code during those hours. That means to make this "work" you need global marketing - not impossible, just more work.
If it's the latter, then I wonder what people will do when a comment is posted on code that is 7 days old? Many times I've written lines and lines of unit tests, integrated the code into many different areas, and moved on into another area/module. A minor refactoring would take us out of our current workflow and be costly. A major refactoring may cause us to delay launch. If the refactoring is high quality it would be worth it. So the key here is finding code reviewers who contribute high quality refactoring ideas.