News for hackers. Stuff that matters.
Re:Xfce switches to GitLab by tardyp on Sunday May 31, 2020 @11:07AM (#23370010)
Ability to review diff between two versions of PR is a great missing feature in GitHub. When dealing with large changes, GitLab review flow is IMHO easier for reviewer. Gitlab store each push of a MR branch as different version (as hidden refs), which make the feature possible. In GH, you force push a branch, you loose the old code for good, so reviewer has to remember why he did that comment before to see if it is still relevant.
Re:Xfce switches to GitLab by noahdesu on Sunday May 31, 2020 @11:51AM (#23370302)
This is such an important feature that has a direct impact on code quality and time savings that I'm not sure why it isn't a priority feature. As a reviewer, having to choose between "review everything again" or "trust the submitter didn't introduce extra changes in the revised pr" is such a terrible choice to have to make.
Re:Xfce switches to GitLab by tobylane on Sunday May 31, 2020 @12:55PM (#23370784)
They added this (reference and comparison to old heads of a PR) at about the start of the year.
Re:Xfce switches to GitLab by tiziano88 on Sunday May 31, 2020 @02:53PM (#23371679)
I think this only works when diffing between commits in the same PR, but not when force pushing the same commit over and over again
Re:Xfce switches to GitLab by tardyp on Sunday May 31, 2020 @01:36PM (#23371080)
Couldn't find the feature today when doing a large review. Do you have to enable it somewhere?
Re:Xfce switches to GitLab by mumblemumble on Sunday May 31, 2020 @02:28PM (#23371495)
In the top left, there should be a "changes from..." drop down menu that will let you choose which commits you want to view. The default is "changes from all commits".

If you're on GitHub Enterprise, availability will depend on the last time your company has installed updates.

Re:Xfce switches to GitLab by tardyp on Sunday May 31, 2020 @03:50PM (#23372137)
That is not the same feature. It requires you to always add your fix in a new commit add opposed to amending the commits and maintain a clear purposed commit list.
Re:Xfce switches to GitLab by mumblemumble on Sunday May 31, 2020 @08:55PM (#23374567)
I think the more official Git way of doing it would be to collect all the changes in separate commits, and then squash merge them at the end of the code review.
Re:Xfce switches to GitLab by 411111111111111 on Sunday May 31, 2020 @03:48PM (#23372122)
that features has been in bitbucket for ages