Re:Show HN: I Made JavaScript Color Conversion Library for L...
by kelsolaar on Friday May 22, 2020 @07:14AM
(#23270826)
Negative numbers are not really an issue, quite the opposite because they are necessary for invertibility of most of the computations. We almost never ever clip values in Colour (https://github.com/colour-science/colour) and leave that responsibility to the user. One exception is conversion to Hexadecimal where if you don't do ensure the values are in the range [0, 1], you will induce the user in error: https://github.com/colour-science/colour/issues/584#issuecom...
Re:Show HN: I Made JavaScript Color Conversion Library for L...
by magicalhippo on Friday May 22, 2020 @07:34AM
(#23270980)
> leave that responsibility to the user
I think it would be better to have a function in the library that does this. Then it can be extended to allow for more clever things than a simple min/max clamp.
Re:Show HN: I Made JavaScript Color Conversion Library for L...
by kelsolaar on Friday May 22, 2020 @07:45AM
(#23271055)
Gamut mapping is not an easy thing though!
Re:Show HN: I Made JavaScript Color Conversion Library for L...
by magicalhippo on Friday May 22, 2020 @01:35PM
(#23274743)
That is true :)
Color is a great example of how "low-order" approximations are very useful, and how quickly it can get very hard once you want to go a bit beyond that.
Also no mention of what kind of RGB it is. From the xyzToRgb function it seems to be[1] sRGB but that should be mentioned, and also consistent throughout the library (in case it isn't).
[1]: http://www.brucelindbloom.com/index.html?Eqn_RGB_XYZ_Matrix....