News for hackers. Stuff that matters.
Re:Every software system used at Gitlab by papaf on Wednesday May 13, 2020 @05:22AM (#23165047)
In my experience, if you are reviewing 800+ line PRs you should be in an IDE. I believe the average human being can not review an 800 line diff reliably.

Such large PRs would also probably benefit from live discussions over video (or in the good old days -- in person).

Re:Every software system used at Gitlab by sa46 on Wednesday May 13, 2020 @11:35AM (#23167902)
Interesting, I’ve only went through the effort of checking out a pull request for review a couple times. What’s the workflow like? Any tips for reducing friction? I avoid checking out PRs because it’s much higher friction and because I trust CI to catch most bugs so the crappy code forge interfaces are good enough.

Personally, I would kill for a one click to step review interface in IntelliJ that synced comments back to the review.

Re:Every software system used at Gitlab by 3001 on Wednesday May 13, 2020 @09:44PM (#23174240)
I use gitlens extension on Visual studio.Pretty great so far.
Re:Every software system used at Gitlab by teen on Wednesday May 13, 2020 @03:54PM (#23171049)
I've reviewed 4000 line MRs without problems using other tools. It is possible.