News for hackers. Stuff that matters.
Re:Every software system used at Gitlab by jbaiter on Wednesday May 13, 2020 @04:07AM (#23164649)
Yeah, this is definitely one of GitLab's weakest points at the moment and seriously impacts day-to-day work here as well. Simple features like ticking off files you've already reviewed are missing and even mid-sized MRs are a pain to review even on a beefy machine.
Re:Every software system used at Gitlab by andr3 on Wednesday May 13, 2020 @09:56AM (#23166910)
Hi! I'm an Engineering Manager at GitLab in Source Code team.

This is on our horizon. We have an Epic to track an overall revamp and adding an option to review file-by-file which will include developing something like what you just described.

Epic: https://gitlab.com/groups/gitlab-org/-/epics/516

Issue for the checking of file seen (including the concept of "unread diffs"): https://gitlab.com/gitlab-org/gitlab/-/issues/24629

If you could please add your thoughts in that issue, we could use that feedback while we develop the feature.

Thanks a bunch for caring and voicing your concerns. It helps us get better.

Re:Every software system used at Gitlab by jbaiter on Wednesday May 13, 2020 @10:14AM (#23167076)
Thanks a lot for taking the time to answer! I hope my criticism didn't come off too strong, overall I love working with GitLab, the parent just struck a chord with one of my pain points. Glad to see you're working on it!
Re:Every software system used at Gitlab by erowtom on Wednesday May 13, 2020 @05:37AM (#23165125)
This feature already exists, I use it all the time.
Re:Every software system used at Gitlab by jbaiter on Wednesday May 13, 2020 @08:22AM (#23166107)
In GitLab? Maybe we're using an outdated GitLab version here, but I can't find it. And it doesn't seem to be mentioned in the offical Reviewing documentation: https://docs.gitlab.com/ce/user/project/merge_requests/revie...

If you mean the "collapsing" feature, this is really not equivalent, since the state does not persist between multiple review sessions.

Re:Every software system used at Gitlab by buttersbrian on Wednesday May 13, 2020 @09:33AM (#23166700)
I don't have it either. I wish we could "check" things off. I also wish I had more ability to do settings "by group", rather than by project.
Re:Every software system used at Gitlab by samanthalee233 on Wednesday May 13, 2020 @11:04AM (#23167559)
Community Advocate at GitLab here, it'd be great if you can add this feedback to this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/24629 Thanks!