I have two kids. I've spent a lot of money to make them healthier, smarter, and happier. I want nothing in return except to see them smile and growing to be a wonderful human being.
Believe it or not, I'm happy.
You can't argue "I'm happy because I have children" because you don't know how happy you would have been without them (and with all the money and freedom they cost.) I want kids myself but it's not an easy question to answer if they actually make parents happier. It obviously makes parents _think_ they're happier but that's not the same thing.
Not in all cultures. In mine, kids are expected to grow up and help parents retire and take care of them in old age. From our eyes, seeing a parent off to a retirement home is the worst thing and reflects poorly on the kids.
Modern statistical tools allow economists to ferret out the most obscure factors. They're remarkably good at this, although not infallible -- our continued poor understanding of macro issues is a glaring example, but the topics being discussed here are decidedly micro.
I think the real answer to your comment is that economic models are (frequently) far more pointed than people like to admit. When they're forced to confront the fact that their observed behavior doesn't match what they espouse, they prefer to shoot the messenger rather than admit that they're not practicing what they preach.
Did you read the article? It doesn't ferret out any obscure factors? It has people read an article and then make some statement. And even then it doesn't even compare against those who don't have kids, but wanted kids or a whole slew of other useful controls.
But more importantly read the headline to the article, "Does having kids make parents delusional" -- yet NONE of the tests were about that. The tests were "Does Pointing out the Benefits of Parenting Reduce Its Perceived Benefit". That's a totally different story.
If you only care about money, having children is obviously not smart, as children generally cost money and don't produce it, even later in life. If you care about a fulfilling life more than a filled bank account, then raising children is one of the most important activities a person can do.