News for hackers. Stuff that matters.

A comment on A one-line package broke `npm create-react-app`. Parent comment

Re:A one-line package broke `npm create-react-app` by odensc on Saturday April 25, 2020 @01:43PM (#22979750)
In theory `x instanceof Promise` would work, but the reason for this package is that there are many non-standard Promise implementations in the JS world.
[ Parent | on HN ]
Re:A one-line package broke `npm create-react-app` by exogen on Saturday April 25, 2020 @05:43PM (#22981814)
It wouldn't work even if everything were native – see my reply above.
[ Parent | on HN ]
Re:A one-line package broke `npm create-react-app` by odensc on Saturday April 25, 2020 @07:02PM (#22982421)
That applies for browsers, yes (though I'd argue is a rare edge-case), but create-react-app is a Node.js application.
[ Parent | on HN ]
Re:A one-line package broke `npm create-react-app` by exogen on Saturday April 25, 2020 @08:10PM (#22982869)
create-react-app isn't even using is-promise directly. It's several hops in the dependency graph away.
[ Parent | on HN ]