Re:Git: Newline injection in credential helper protocol
by floatingatoll on Thursday April 16, 2020 @10:12AM
(#22889537)
Previously on HN (2 comments, yesterday): https://news.ycombinator.com/item?id=22876108
Re:Git: Newline injection in credential helper protocol
by asdfqwerty18 on Thursday April 16, 2020 @10:19AM
(#22889603)
thanks
Re:Git: Newline injection in credential helper protocol
by kyrra on Thursday April 16, 2020 @10:13AM
(#22889550)
I wonder how this fix behaves with '\r' on all platforms. Obviously the primary systems (windows/osx/linux/bsd) all use \n or \r\n, but I'm wondering if Git has been ported to more obscure systems that only use \r [0], and how this fix would behave there.
Malicious URLs may cause Git to present stored credentials to the wrong server - https://github.com/git/git/security/advisories/GHSA-qm7j-c96...
..And the commit that fixed it:
https://github.com/git/git/commit/9a6bbee8006c24b46a85d29e7b...