News for hackers. Stuff that matters.
Re:Show HN: Fdir – Faster Node.js glob alternative by 29athrowaway on Sunday March 29, 2020 @11:10PM (#22724895)
- There are millions of modules on npm and you are claiming this is the fastest of them all? I doubt it, and not only I doubt it: I find it misleading since it's hard to verify and reflects a lack of humility. To say "Our goal is to have the fastest node module" or "A module with performance in mind" is VERY different to "The fastest module".

- If I decide to use your code for something serious I cannot take your numbers for granted. The benchmark methodology does matter. You need show some signs of rigor so other people can assess how credible your claims are.

- Did you run this benchmark in a controlled environment without other processes running? Did you disable frequency scaling before running your benchmark? If you ran it in a desktop computer with a bunch of other stuff running and frequency scaling enabled then your processor speed was constantly oscillating while running your benchmark and the numbers are completely random.

- Did you know that v8 is full of optimizations that are conditional to how your code is written? Did you know that even a comment can dramatically affect how your code is treated by v8? In some cases V8 just gives up trying to optimize your code. Did you profile your code? did you trace v8 deoptimizations? Even if you did, you should not say this:

    Why are all the other libraries so slow?

    Because they did not spend enough time optimizing it.
    Most developers give readability and cool code more importance
    than actual performance and usability.
It's really the self-promoting tone and unbelievable claims that make the README file so irritating.

There are no comments on this comment yet.