Show HN: Fdir – Faster Node.js glob alternative

Re:Show HN: Fdir – Faster Node.js glob alternative by lhorie on Sunday March 29, 2020 @06:29PM (#22723378)

This here looks wrong: https://github.com/thecodrr/fdir/blob/master/index.js#L86 It's calling a blocking method from async in Node <10

Another thing I noticed, it looks you only handle `dirent.isDirectory()`, but not `dirent.isSymbolicLink()` (meaning the library won't find files in symlinked folders, e.g. lerna node_modules)

[ Parent | on HN ]

Re:Show HN: Fdir – Faster Node.js glob alternative by thecodrr on Sunday March 29, 2020 @08:56PM (#22724246)

Hey, thanks for taking the interest.

Yes, that sync method call is intentional (for now) +. I have been meaning to add separate lstat call for async/sync for < node 10 without impacting performance. So that will change. Thanks for pointing that out.

Handling symlinks is work in progress. (it will be exposed as an option that you can enable/disable because symlinks resolution is expensive and not everyone wants that).

[ Parent | on HN ]

Re:Show HN: Fdir – Faster Node.js glob alternative by 29athrowaway on Sunday March 29, 2020 @06:54PM (#22723528)

> Because they did not spend enough time optimizing it. Most developers give readability and cool code more importance than actual performance and usability.

Aged like milk.

[ Parent | on HN ]