Re:Release to NPM and Docker Hub with GitHub Actions and Con...
by derberg on Friday March 20, 2020 @10:50AM
(#22637947)
I wanted to also introduce PR title validation, so there is no mistake possible on merging and we follow convetional commits 100% but unfortunately GitHub Actions do not support fork-based workflow properly and those PR checks would be useless :(
[ Parent
| on HN ]
Re:Release to NPM and Docker Hub with GitHub Actions and Con...
by time0ut on Friday March 20, 2020 @10:53AM
(#22637974)
Oh, that is unfortunate. Hopefully they fix that. For now, it might be worth writing a little bot that will flag PRs with noncompliant commit messages and titles.
Re:Release to NPM and Docker Hub with GitHub Actions and Con...
by jakear on Friday March 20, 2020 @11:04AM
(#22638066)
> GitHub Actions do not support fork-based workflow properly
Could you elaborate on this?
Re:Release to NPM and Docker Hub with GitHub Actions and Con...
by derberg on Friday March 20, 2020 @11:37AM
(#22638419)
Take a look on my blog post about it https://dev.to/derberg/github-actions-when-fascination-turns.... I already reported this to GitHub Actions team and seems they are working on that. For reference https://github.community/t5/GitHub-Actions/GitHub-Action-wor...
Re:Release to NPM and Docker Hub with GitHub Actions and Con...
by jakear on Friday March 20, 2020 @12:04PM
(#22638675)
Ah yes, fork. My mind read that as branch as we barely ever use forks (enterprise environment and all)
Issue comment-triggered Actions have a write-access GITHUB_TOKEN, unless I’m mistaken. You could implement the /ok-to-test flow with that.
(I’m working on converting some of VSCode’s triage automation to Actions, for reference)
Re:Release to NPM and Docker Hub with GitHub Actions and Con...
by derberg on Friday March 20, 2020 @01:01PM
(#22639175)
Guy from GitHub suggested the same, but how would you really see such workflow in action? all I have in mind seems so complicated that easier would be to write and host dedicated bot really. Supporting PR on Issue level sounds strange