So what sort of geometry would they have, toroidal, cylindrical ? I was initially thinking you meant they would be spheres but I'm not sure how you would generate gravity on a sphere, unless only the equatorial region was inhabited.

The type of habitat he is describing is known as an O'Neil cylinder. The wikipedia page for the topic probably answers most questions you have about it.

https://en.wikipedia.org/wiki/O'Neill_cylinder