News for hackers. Stuff that matters.
Re:I found and fixed a bug in PHP's standard library by osrec on Sunday March 01, 2020 @08:39PM (#22460846)
Looking at lines 460-521 in the modified file (https://github.com/miguelxpn/php-src/blob/f4b2089b642d504be3...), is there not a benefit to `break` out of the while loop in the nested if statements?

Otherwise, it looks like it will call strstr() one extra time, even though you may have already determined that the specific header is present.

Re:I found and fixed a bug in PHP's standard library by miguelxpn on Sunday March 01, 2020 @08:43PM (#22460871)
Good catch! That's indeed the case. Another commit was made where that piece of code was refactored into a function and it returns 1 in case the header is present so strstr isn't being called an extra time in the current code.

[1] https://github.com/php/php-src/commit/3d9c02364db62a6d8e2794...

Re:I found and fixed a bug in PHP's standard library by osrec on Sunday March 01, 2020 @08:45PM (#22460879)
Ah, much cleaner!