News for hackers. Stuff that matters.
Re:OpenWRT remote code execution via MITM due to bug in pack... by DSMan195276 on Saturday February 01, 2020 @03:22AM (#22209425)
Yeah, yuck, this definitely could have been avoided if they did some proper lexing/parsing before dealing with the line, instead of manually separating things apart after matching on the beginning of the string...

That said, perhaps it's just too early in the morning but I don't think that commit introduced the error. The math/logic looks to be identical and I think the bug is `line + strlen("SHA256sum") + 1` which was already there before and doesn't increment past any spaces which might come after the (implied I guess?) colon. Though considering the colon isn't checked for in `SHA256sum`, you could put any character there and it'll work. Yay...

Re:OpenWRT remote code execution via MITM due to bug in pack... by plapetomain on Saturday February 01, 2020 @04:53AM (#22209683)
Nice catch I think. I’ll be damned if I can see a difference. Looks like the old code will also skip the checksum in the case of any non hexdigit padding.