Here’s my problem with the approach: it’s a compiler warning. Nobody looks at those so it’s configured to be treated as an error. Now you have to deal with false positives and differences between implementations across compilers. I’d rather have this be part of the language with string guarantees and an obligation for compilers to adhere to the spec. Of course that isn’t possible in C++ without breaking existing code, which is why this ended up where it is.