Re:Ask HN: How do you handle conflicts with your peers?
by jimmyvalmer on Sunday January 19, 2020 @09:03PM
(#22095651)
> puts a high cost on making constructive recommendations.
A "constructive recommendation" is fine, so long as the reviewer still clicks
"Accept" on the PR instead of "Requests changes." Otherwise, reviewer must
make the change himself. It's called "work" for a reason.
> Requiring others to fix bad code... removes an incentive write good code.
I don't think you understand programmers then. It's an exacting profession --
it's against our nature to embarrass ourselves like that.
A "constructive recommendation" is fine, so long as the reviewer still clicks "Accept" on the PR instead of "Requests changes." Otherwise, reviewer must make the change himself. It's called "work" for a reason.
> Requiring others to fix bad code... removes an incentive write good code.
I don't think you understand programmers then. It's an exacting profession -- it's against our nature to embarrass ourselves like that.