Re:Show HN: Darken – Darkmode Made Easy
by Call_in on Thursday January 16, 2020 @09:20PM
(#22071276)
I understand the concept of what you are doing, but I think those two methods have different use cases, yours may be more performant but mine, I feel, is more simple for everyday usage. I'll definitly look your work more in depth. Thanks for the feedback!
[ Parent
| on HN ]
Re:Show HN: Darken – Darkmode Made Easy
by woutr_be on Thursday January 16, 2020 @10:19PM
(#22071555)
I was also a bit confused as to why the title was "DarkMode Made Easy", especially since your example just showed adjusting CSS variables. I would assume anyone who's working with CSS variables, also knows about media queries, so it's far easier to just do it all in CSS.
Where I could see this being useful is that you have a callback that you can use, so when dark mode is enabled, you can make some other adjustments when needed.
Re:Show HN: Darken – Darkmode Made Easy
by Call_in on Thursday January 16, 2020 @10:38PM
(#22071644)
You'll have a callback on the next version. I plan a lot of tweaks and features that can hardly be done only in CSS, moreover the plan is to give devs an easy way to do dark-modes. I understand the divergences and critics but want to try things as a student. I thanks you a lot for your review.
Don’t get me wrong, it’s great. Just that with the current examples it’s not that useful to me. Callbacks would be cool!
Re:Show HN: Darken – Darkmode Made Easy
by chrismorgan on Friday January 17, 2020 @07:09AM
(#22073965)
I honestly recommend writing your own. The code is presently close to trivial, and if you write such a thing yourself you can take it in the direction that suits your requirements.